Fix ask question speedbump dropdown selection#11305
Conversation
Ensure the Ask-User-Question speedbump dropdown initializes and updates its selected item from the active execution profile so the closed header does not render blank. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR scopes the Ask-User-Question speedbump dropdown fix to the inline view by seeding the dropdown header from the active execution profile during initialization and updating it immediately when a permission is selected.
Concerns
⚠️ [IMPORTANT] This is a user-facing dropdown behavior change, but the PR description does not include screenshots or a screen recording demonstrating the initial populated header and the selection update end to end. Please attach visual evidence before merge.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| self.selected_item = self.selected_item(ctx); | ||
| ctx.notify(); |
There was a problem hiding this comment.
Is this still ncessary? do we use select_action_and_close in ask question dropdown? in any case, we should verify this doesn't do something unexpected for the other consumers.
There was a problem hiding this comment.
removed the above and changed to ensure we have an option selected
Co-Authored-By: Oz <oz-agent@warp.dev>
coolcom200
force-pushed
the
leon/ask-user-question-dropdown-selection
branch
from
aff051c to
b073d1a
Compare
2 participants
Description
Fixes the Ask-User-Question autonomy speedbump dropdown so the closed header is populated from the active execution profile on initialization and updates immediately when a permission is selected.
The fix stays scoped to the Ask-User-Question view instead of changing shared dropdown behavior.
Warp Agent Mode conversation: https://staging.warp.dev/conversation/7f70dcc8-f0b5-4e7b-8a8d-3f1c4dde5af5
Linked Issue
ready-to-specorready-to-implement.Testing
cargo fmtcargo clippy --all-targets --all-features --tests -- -D warningsgit --no-pager diff --check./script/runScreenshots / Videos
Draft PR: screenshots or a short recording should be attached before review to show the dropdown header populated on initial render and after selecting another option.
Agent Mode
CHANGELOG-BUG-FIX: Fixed the Ask-User-Question speedbump dropdown header appearing blank after initialization or selection.
Co-Authored-By: Oz oz-agent@warp.dev